Enable easy passing of environment variables in browser.script.iffe.js#649
Open
ledsun wants to merge 1 commit into
Open
Enable easy passing of environment variables in browser.script.iffe.js#649ledsun wants to merge 1 commit into
browser.script.iffe.js#649ledsun wants to merge 1 commit into
Conversation
ledsun
changed the title
browser.script.iffe.js
ledsun
force-pushed
the
codex/browser-script-data-env
branch
3 times, most recently
from
31b13db to
750f4b4
Compare
ledsun
force-pushed
the
codex/browser-script-data-env
branch
from
750f4b4 to
ffc508f
Compare
kateinoigakukun
left a comment
kateinoigakukun
left a comment
Member
There was a problem hiding this comment.
Thanks for adding this! Overall good things to add 👍
Comment on lines
+112
to
+132
| const trimmedEnv = rawEnv.trim(); | ||
| if (!trimmedEnv) { | ||
| return {}; | ||
| } | ||
|
|
||
| return trimmedEnv | ||
| .split(/\s+/) | ||
| .reduce<Record<string, string>>((env, entry) => { | ||
| const delimiterIndex = entry.indexOf("="); | ||
| if (delimiterIndex <= 0) { | ||
| console.warn( | ||
| `data-env entry must be in the KEY=value format. ${entry} is ignored.`, | ||
| ); | ||
| return env; | ||
| } | ||
|
|
||
| // Only the first "=" separates key and value so values can contain "=". | ||
| env[entry.slice(0, delimiterIndex)] = entry.slice(delimiterIndex + 1); | ||
| return env; | ||
| }, {}); | ||
| }; |
Member
There was a problem hiding this comment.
This makes values containing spaces impossible to express, and technically env var keys can also contain spaces (POSIX allows any byte except = and \0 in a key name).
What about just accepting inline JSON string like below?
<script
src=".../browser.script.iife.js"
data-env='{"RUBY_BOX":"1","RUBY_FIBER_MACHINE_STACK_SIZE":"1048576","MSG":"hello world"}'
></script>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is intended to meet the expectations of #645 (comment).
Summary
browser.script.iife.jssupport for passing Ruby VM environment variables via adata-envattributeRuby::Boxexample that enablesRUBY_BOX=1throughdata-envdata-envand theRuby::Boxexample with Playwright tests, and documentdata-envin the cheat sheetNotes
data-envsupport.Ruby::Boxexample:Ruby::BoxrequiresRUBY_BOX=1at VM startup.Ruby::Box's require hook copies extension libraries to/tmpbefore loading them./tmp, so theRuby::Boxexample does not work there yet.Ruby::Boxis not available there.tmpis not currently provided.Ruby::Boxwork on WASI Preview 2, the Preview 2 browser filesystem needs a writable preopen equivalent to/tmp.data-envPR.