Apply default tool annotation hints from McpServerToolAttribute#1674
Open
goutamadwant wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply the documented default values for tool annotation hints when tools are created from
McpServerToolAttribute.Motivation and Context
Fixes #1673.
McpServerToolAttributeexposes default values forDestructive,Idempotent,OpenWorld, andReadOnly, but tool creation only copied values from the attribute's nullable backing fields. That meant default hint values were not included in the generated tool annotations unless the attribute explicitly set each property.This change derives those hints from the attribute's public properties, while keeping explicit
McpServerToolCreateOptionsvalues as overrides.How Has This Been Tested?
dotnet test tests/ModelContextProtocol.Tests/ModelContextProtocol.Tests.csproj -f net10.0 --filter FullyQualifiedName~McpServerBuilderExtensionsToolsTests.Create_ExtractsToolAnnotations_SomeSetdotnet test tests/ModelContextProtocol.Tests/ModelContextProtocol.Tests.csproj -f net10.0 --filter FullyQualifiedName~McpClientTests.ListToolsAsync_AllToolsReturneddotnet test tests/ModelContextProtocol.Tests/ModelContextProtocol.Tests.csproj -f net10.0 --no-restoreThe full
net10.0test project passed locally: 2219 passed, 5 skipped.Breaking Changes
None.
Types of changes
Checklist
Additional context
No documentation update is included because this change aligns runtime behavior with the existing documented defaults. No new error handling is needed for this annotation derivation change.