fix: send push notifications for permission requests when user is not focused#1765
Open
thaning0 wants to merge 1 commit into
Open
fix: send push notifications for permission requests when user is not focused#1765thaning0 wants to merge 1 commit into
thaning0 wants to merge 1 commit into
Conversation
… focused Skip the 180s presence window for permission reason. The focus check (appVisible && focusedAgentId === agent.id) still applies — no push if the user is literally looking at the agent. Fixes getpaseo#1764
81b4a6e to
4545bd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1764
Problem
When an agent asks the user a question (permission request), Paseo suppresses push notifications if any client was active within 180 seconds — even if the user is on a different page and won't see the in-app dialog.
Fix
Add a
skipPresenceparameter tocomputeNotificationPlan. Forpermissionreason, skip the 180s presence window. The focus check (appVisible && focusedAgentId === agent.id) still applies: no push if the user is literally looking at the agent.Changes
agent-attention-policy.ts: Add optionalskipPresenceflag. When true, all clients are treated as absent regardless of recent activity.websocket-server.ts: PassskipPresence: params.reason === "permission"tocomputeNotificationPlan.