Feat: Elsa2 Enhance TypeScript generation and type utilities#7696
Open
terry-delph wants to merge 1 commit into
Open
Feat: Elsa2 Enhance TypeScript generation and type utilities#7696terry-delph wants to merge 1 commit into
terry-delph wants to merge 1 commit into
Conversation
…#7540 - Added `IsNullableType` extension method for nullable type checks. - Made `Priority` property in `DefaultActivityTypeDefinitionRenderer` virtual to allow correct priorty to be used when subclassing - Replaced a usage of `AutoMapper.Internal` with `Elsa.Scripting.JavaScript.Extensions`. IsNullableType method. - Improved `RenderTypeDeclaration` to handle enums and class constructors. - Updated `EnumTypeDefinitionProvider` to refine enum handling and definitions.
Contributor
|
PR author is not in the allowed authors list. |
Contributor
Author
|
@sfmskywalker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsNullableTypeextension method for nullable type checks.Priorityproperty inDefaultActivityTypeDefinitionRenderervirtual to allow correct priorty to be used when subclassingAutoMapper.InternalwithElsa.Scripting.JavaScript.Extensions. IsNullableType method.RenderTypeDeclarationto handle enums and class constructors.EnumTypeDefinitionProviderto refine enum handling and definitions.Purpose
This PR enhances Elsa 2's TypeScript definition generation to include .NET class constructor signatures and correctly render enums instead of treating them as plain numbers. These changes provide full IntelliSense support and autocomplete functionality for workflow authors using JavaScript expressions.
Scope
Select one primary concern:
Description
Problem
Currently,
DotNetTypeScriptDefinitionProviderdoes not display constructors for .NET classes, making it unclear which overloads are available during JavaScript type instantiation. Additionally, theEnumDefinitionProviderrenders enums as generic numbers (e.g., DayOfWeek: number;), hiding the actual enum names and values from the editor.Solution
Verification
Steps:
Expected outcome:
Screenshots / Recordings (if applicable)
Target TypeScript Definition Output Example:
Checklist