[Ubuntu] Add PostgreSQL to arm64 images#14234
Open
enescakir wants to merge 1 commit into
Open
Conversation
x64 images already have PostgreSQL installed. Since `psql` is such a popular tool among developers, and GitHub now maintains arm64 images, it makes sense to install it on arm64 images as well.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR enables PostgreSQL on Ubuntu ARM64 images and surfaces it in validation + software reporting.
Changes:
- Adds the PostgreSQL install script to Ubuntu 22.04/24.04/26.04 ARM64 Packer builds.
- Enables the PostgreSQL Pester test on ARM64.
- Includes PostgreSQL in the generated “Databases” software report regardless of architecture.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| images/ubuntu/templates/build.ubuntu-26_04-arm64.pkr.hcl | Adds PostgreSQL install step to the ARM64 image build. |
| images/ubuntu/templates/build.ubuntu-24_04-arm64.pkr.hcl | Adds PostgreSQL install step to the ARM64 image build. |
| images/ubuntu/templates/build.ubuntu-22_04-arm64.pkr.hcl | Adds PostgreSQL install step to the ARM64 image build. |
| images/ubuntu/scripts/tests/Databases.Tests.ps1 | Runs PostgreSQL validation on ARM64 by removing the skip. |
| images/ubuntu/scripts/docs-gen/Generate-SoftwareReport.ps1 | Always emits PostgreSQL section in the software report. |
Comment on lines
259
to
265
| # Databases | ||
| $databasesTools = $installedSoftware.AddHeader("Databases") | ||
| $databasesTools.AddToolVersion("sqlite3", $(Get-SqliteVersion)) | ||
| if (Test-IsX64) { | ||
| $databasesTools.AddNode($(Build-PostgreSqlSection)) | ||
| } | ||
| $databasesTools.AddNode($(Build-PostgreSqlSection)) | ||
| $databasesTools.AddNode($(Build-MySQLSection)) | ||
| if (Test-IsUbuntu22-X64) { | ||
| $databasesTools.AddNode($(Build-MSSQLToolsSection)) |
Comment on lines
+1
to
4
| Describe "PostgreSQL" { | ||
| It "PostgreSQL Service" { | ||
| "sudo systemctl start postgresql" | Should -ReturnZeroExitCode | ||
| "pg_isready" | Should -OutputTextMatchingRegex "/var/run/postgresql:5432 - accepting connections" |
Contributor
Author
|
Hi @v-SergeiRadich, @shamil-mubarakshin, What do you think about making the arm64 image more similar to x64? |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x64 images already have PostgreSQL installed. Since
psqlis such a popular tool among developers, and GitHub now maintains arm64 images, it makes sense to install it on arm64 images as well.Related issue:
Check list